Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template elements do not insert into custom component #105

Closed
g105b opened this issue Nov 14, 2019 · 0 comments
Closed

Template elements do not insert into custom component #105

g105b opened this issue Nov 14, 2019 · 0 comments
Assignees
@g105b

Comments

@g105b
Copy link
Member

g105b commented Nov 14, 2019

If a component HTML contains a data-template, using insertTemplate does not work.

I have just noticed this when using bindList on an element within a component html file.
@g105b g105b self-assigned this Nov 14, 2019
g105b added a commit that referenced this issue Nov 14, 2019
@g105b
Isolate bug for #105 - use README example
096ac6f
g105b added a commit that referenced this issue Nov 27, 2019
@g105b
Simplify the mechanisms behind bind* functions. (#111)
7468beb 
* Fix return type for getElementById, closes #65

* Update PHPDoc to include inherited changes

* Rename function for removing template attributes

* Set value for certain input fields differently

* Bind list to document fragment for efficiency
for #77

* Remove unbindable check

* Allow returning any iterable, not just array - fixes #88

* Test that multiple kvps can be bound within the same parameter

* Isolate bug for #105 - use README example

* Rename BindDataGetter -> BindObject

* Tidy up bindData function

* Test incompatible bindData types

* Remove bindNestedList function

* Testing bindValue

* Test bindObjectValue

* Test bindValue within lists

* Bindable type checking

* Simplify bind functions, closes #110

* Skip empty lists
g105b added a commit that referenced this issue Dec 11, 2019
@g105b
Extract templates after expanding components. Closes #105
fb4ec75
@g105b g105b closed this as completed in fcccb78 Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g105b g105b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@g105b