Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected display problems in MoveSelectedTool and LivePreviewManager #115

Merged
merged 8 commits into from
Apr 27, 2016
Merged

Conversation

codeprof
Copy link
Contributor

  • changing ctx.Operator before a call to layer.Draw(...) has no effect because the BlendMode is overwritten by layer.Draw(...).
    The error can be seen e.g. when having a colored semi-transparent image and apply a black and white filter. In the regions of the image where alpha is != 255 there remain colored parts.
  • Layerproperties are corretly applied if "MoveSelectionTool" is active, but not if "MoveSelectedTool" is active.
  • MoveSelectedTool does not react on changes in Opacity, Visibility and BlendMode

@robpvn
Copy link
Member

robpvn commented Mar 29, 2016

I no longer feel confident about making decisions on things not not directly related to addins, so @cameronwhite will have to make an opinion here I think. But I can say that there is a problem with indentation caused by tabs vs. spaces here too, which will need correcting. 👌

@codeprof
Copy link
Contributor Author

Updated intends (by replacing 4 spaces with tab, don't know why mono used spaces...)

@@ -421,7 +421,9 @@ public void FinishSelection ()
Layer layer = SelectionLayer;

using (Cairo.Context g = new Cairo.Context (CurrentUserLayer.Surface)) {
layer.Draw(g);
//layer.Draw(g);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this line instead of leaving it commented out? Otherwise, the changes look good

@codeprof
Copy link
Contributor Author

@cameronwhite
Are there still obstacles preventing you from merging this? If so I will try to improve :-)

@cameronwhite
Copy link
Member

Looks good - I just didn't see the new commit.

@cameronwhite cameronwhite merged commit ad23dab into PintaProject:master Apr 27, 2016
@codeprof
Copy link
Contributor Author

no problem. Thank you for merging it :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants