-
Notifications
You must be signed in to change notification settings - Fork 5
Fix skipping lint of ESM components preceded by other statements #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Run rule checks on nodes of type `ExportDefaultDeclaration` instead of `Program`
@js07 nice! Could you also help with two related things:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great and tests are running locally for me!
😃 For reference, I added test cases for ESM components whose I think this PR is ready to be merged barring other suggested changes. |
Yes feel free to merge and update the |
Forgot you didn't have write permissions here, so I merged this one and invited you to the repo. I'll also publish the most recent version to npm (another thing we need to automate!) Let me know if you can merge the GH Actions PR, or if that doesn't work. |
Merging the GH Actions PR worked for me. |
New version adds bug fix for missing ESLint validation on some ESM components See PipedreamHQ/eslint-plugin-pipedream#6
New version adds bug fix for missing ESLint validation on some ESM components See PipedreamHQ/eslint-plugin-pipedream#6
New version adds bug fix for missing ESLint validation on some ESM components See PipedreamHQ/eslint-plugin-pipedream#6
Program
AST nodes to onExportDefaultDeclaration
nodesrules.test.js
for ESM components with statements beforeexport default
declarationrules.test.js
Fixes #5