Fix eslint failing with TypeError when default export is not an object #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
TypeError
when default export is not an object (with properties)Context
When linting
.mjs
files with adefault export
that is not an object, ESLint throwsTypeError: Cannot read property 'map' of undefined
.This error happens because
propertyArray.map()
is called in cases wherepropertyArray
could beundefined
instead of an array. Specifically, in component checks whereisDefaultExport(node)
, butnode.declaration
is something other than anObjectExpression
(e.g. anArrayExpression
),node.declaration.properties
(i.e.component.properties
) isundefined
.For example:
ESLint would fail when linting this file (
region-data.mjs
):To reproduce:
5e5832e81ba8fd2a1f55745221ff480ea41257e3
of branchfeature/reddit-new-actions