-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Pinning Notion client version #18292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,11 +4,11 @@ | |
key: "notion-retrieve-page", | ||
name: "Retrieve Page Metadata", | ||
description: "Get details of a page. [See the documentation](https://developers.notion.com/reference/retrieve-a-page)", | ||
version: "0.0.10", | ||
version: "0.0.11", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainLGTM – metadata bump to trigger publish. No functional changes. Given the PR intent (pinning @notionhq/client to 4.0.2), this version bump is appropriate to republish the action. To ensure the pin is truly effective across the repo and CI images (no hoisted 5.x), run: If any 5.x appears, add a root-level override/resolution to force 4.0.2 and update the lockfile. 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "1) List all declared versions of @notionhq/client across package.json files"
rg -nP '"@notionhq/client"\s*:\s*"[^\"]+"' -g '**/package.json' -S || true
echo
echo "2) Confirm no caret (^) ranges for @notionhq/client"
rg -nP '"@notionhq/client"\s*:\s*"\^' -g '**/package.json' -S || true
echo
echo "3) Check lockfiles for any 5.x resolution"
for f in pnpm-lock.yaml yarn.lock package-lock.json; do
if [[ -f "$f" ]]; then
echo "Scanning $f"
rg -nP '@notionhq/client@?[^"\s]*5\.' "$f" || true
fi
done
echo
echo "4) If using pnpm/yarn/npm, optionally verify the installed graph:"
command -v pnpm >/dev/null && pnpm why @notionhq/client || true
command -v yarn >/dev/null && yarn why @notionhq/client || true
command -v npm >/dev/null && npm ls @notionhq/client || true Length of output: 2851 Pin @notionhq/client in components/notion_api_key/package.json 🤖 Prompt for AI Agents
|
||
type: "action", | ||
props: { | ||
notion, | ||
infoLabel: { | ||
Check warning on line 11 in components/notion/actions/retrieve-page/retrieve-page.mjs
|
||
type: "alert", | ||
alertType: "info", | ||
content: "If you need to retrieve page content or block objects, use the **Retrieve Page Content** action instead.", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ export default { | |
key: "notion-update-page", | ||
name: "Update Page", | ||
description: "Update a page's property values. To append page content, use the *Append Block* action instead. [See the documentation](https://developers.notion.com/reference/patch-page)", | ||
version: "1.1.9", | ||
version: "1.1.10", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainVerify pin consistency and guard against accidental 5.x upgrades. Confirm every package.json pins Run: Optionally add a Renovate rule to block majors: {
"packageRules": [
{
"matchPackageNames": ["@notionhq/client"],
"allowedVersions": "<5.0.0",
"rangeStrategy": "pin"
}
]
} 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "Occurrences of @notionhq/client versions:"
rg -nP --glob '**/package.json' -S '"@notionhq/client"\s*:\s*"[^"]+"' -C0 || true
echo
echo "Checking for non-pinned ranges (^ or ~):"
if rg -nP --glob '**/package.json' -S '"@notionhq/client"\s*:\s*"[~^]' ; then
echo "Found non-pinned ranges above."
exit 1
fi
echo
echo "Checking for any 5.x references:"
if rg -nP --glob '**/package.json' -S '"@notionhq/client"\s*:\s*"(5\.[^"]*)"' ; then
echo "Found 5.x references above."
exit 1
fi
echo
echo "Lockfiles present:"
fd -t f 'package-lock.json' 'yarn.lock' 'pnpm-lock.yaml' || true Length of output: 656 Pin @notionhq/client to exact 4.x in all package.json
🤖 Prompt for AI Agents
|
||
type: "action", | ||
props: { | ||
notion, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ export default { | |
key: "notion-new-comment-created", | ||
name: "New Comment Created", | ||
description: "Emit new event when a new comment is created in a page or block. [See the documentation](https://developers.notion.com/reference/retrieve-a-comment)", | ||
version: "0.0.6", | ||
version: "0.0.7", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainVerify the Notion SDK is truly pinned repo-wide to avoid accidental 5.x upgrades. Run this to confirm exact pinning and absence of ranges elsewhere. 🏁 Script executed: #!/bin/bash
set -euo pipefail
# 1) Confirm components/notion/package.json pins exactly 4.0.2
pkg="components/notion/package.json"
if [[ -f "$pkg" ]]; then
ver=$(jq -r '.dependencies["@notionhq/client"] // empty' "$pkg")
echo "@notionhq/client in $pkg => ${ver:-<missing>}"
test "$ver" = "4.0.2" || { echo "ERROR: Not pinned to 4.0.2"; exit 1; }
else
echo "ERROR: $pkg not found"; exit 1
fi
# 2) Search for any other version specs or ranges (caret/tilde) in the repo
echo
echo "All @notionhq/client specs:"
rg -nP '"@notionhq/client"\s*:\s*".+?"' -g '!**/node_modules/**' || true
echo
echo "Checking for range specifiers (^ or ~):"
if rg -nP '"@notionhq/client"\s*:\s*"[\^~]' -g '!**/node_modules/**'; then
echo "ERROR: Found range specifiers for @notionhq/client"
exit 1
else
echo "OK: No range specifiers found."
fi
# 3) Optional: ensure no root overrides/resolutions contradict the pin
echo
echo "Overrides/resolutions referencing @notionhq/client (if any):"
rg -nP '"(overrides|resolutions)"\s*:\s*{[^}]*@notionhq/client' -g '!**/node_modules/**' || true Length of output: 989 Pin @notionhq/client exact version repo-wide |
||
type: "source", | ||
dedupe: "unique", | ||
props: { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Ensure the pin is enforced repo-wide (avoid accidental 5.x).
Add a repo-level override/resolution to force
@notionhq/client@4.0.2
and verify no packages depend on^5
. Script below checks all package.jsons and the lockfile for stray 5.x.🏁 Script executed:
Length of output: 426
🏁 Script executed:
Length of output: 262357
Pin @notionhq/client consistently at 4.0.2
components/notion_api_key/package.json currently specifies
^2.3.0
—update it to4.0.2
or add a root-level"overrides": { "@notionhq/client": "4.0.2" }
(npm) /"resolutions": { "@notionhq/client": "4.0.2" }
(Yarn) to enforce this repo-wide.🤖 Prompt for AI Agents