Notion api key client version #18293
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
WalkthroughPatch version bump from 0.0.1 to 0.0.2 across multiple Notion API Key actions and sources. Package version increased from 0.1.0 to 0.1.2 with dependency updates: @notionhq/client to 4.0.2 and @pipedream/notion to ^0.10.1. No logic or structural code changes in modules. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/notion_api_key/package.json (1)
16-18: Consider pinning @pipedream/notion for reproducible builds.
You pinned @notionhq/client exactly, but left @pipedream/notion with a caret. If you want fully deterministic installs for this package, pin it too."dependencies": { - "@notionhq/client": "4.0.2", - "@pipedream/notion": "^0.10.1" + "@notionhq/client": "4.0.2", + "@pipedream/notion": "0.10.1" }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (20)
components/notion_api_key/actions/append-block/append-block.mjs(1 hunks)components/notion_api_key/actions/create-comment/create-comment.mjs(1 hunks)components/notion_api_key/actions/create-page-from-database/create-page-from-database.mjs(1 hunks)components/notion_api_key/actions/create-page/create-page.mjs(1 hunks)components/notion_api_key/actions/duplicate-page/duplicate-page.mjs(1 hunks)components/notion_api_key/actions/query-database/query-database.mjs(1 hunks)components/notion_api_key/actions/retrieve-block/retrieve-block.mjs(1 hunks)components/notion_api_key/actions/retrieve-database-content/retrieve-database-content.mjs(1 hunks)components/notion_api_key/actions/retrieve-database-schema/retrieve-database-schema.mjs(1 hunks)components/notion_api_key/actions/retrieve-page-property-item/retrieve-page-property-item.mjs(1 hunks)components/notion_api_key/actions/retrieve-page/retrieve-page.mjs(1 hunks)components/notion_api_key/actions/search/search.mjs(1 hunks)components/notion_api_key/actions/update-page/update-page.mjs(1 hunks)components/notion_api_key/package.json(2 hunks)components/notion_api_key/sources/new-comment-created/new-comment-created.mjs(1 hunks)components/notion_api_key/sources/new-database/new-database.mjs(1 hunks)components/notion_api_key/sources/new-page/new-page.mjs(1 hunks)components/notion_api_key/sources/page-or-subpage-updated/page-or-subpage-updated.mjs(1 hunks)components/notion_api_key/sources/updated-page-id/updated-page-id.mjs(1 hunks)components/notion_api_key/sources/updated-page/updated-page.mjs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Lint Code Base
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
🔇 Additional comments (24)
components/notion_api_key/sources/new-comment-created/new-comment-created.mjs (1)
14-14: Version metadata bump only — LGTM.
No behavioral changes; safe to publish.components/notion_api_key/package.json (1)
3-3: Verify Notion client v4 upgrade compatibility and runtime.
- No direct imports of @notionhq/client remain in JS/TS code.
- All notion_api_key components use internal version "0.0.2"—no v0.0.1 found.
- Project package.json “engines” require Node ≥18.0.0 (client’s minimum is ≥12).
- Manually confirm @pipedream/notion@^0.10.1 fully supports @notionhq/client 4.0.2 breaking changes (polymorphic page properties, TS types update, new endpoints).
components/notion_api_key/actions/retrieve-page/retrieve-page.mjs (1)
14-14: Version metadata bump only — LGTM.
No logic changes; aligns with the package version update.components/notion_api_key/actions/search/search.mjs (1)
14-14: Version metadata bump only — LGTM.
Consistent with other actions/sources.components/notion_api_key/actions/duplicate-page/duplicate-page.mjs (1)
14-14: Version metadata bump only — LGTM.
No behavioral impact.components/notion_api_key/sources/updated-page/updated-page.mjs (3)
14-14: LGTM: metadata-only version bump.Consistent with the PR’s package updates; no behavior change.
14-14: Verified version consistency for Notion API Key components
All components are at 0.0.2 and dependencies match (@notionhq/client 4.0.2, @pipedream/notion ^0.10.1).
14-14: Confirmed Node.js ≥18 requirement for @notionhq/client v4.x
This SDK version moved to an isomorphic fetch implementation and requires Node.js 18 or newer (per release notes and registry) [1][2]. No changes in this file—ensure your CI,package.jsonengines, and deployment environments use Node.js 18+.components/notion_api_key/actions/retrieve-database-schema/retrieve-database-schema.mjs (1)
14-14: LGTM: version field bump only.Aligned with the broader release; no functional changes.
components/notion_api_key/sources/page-or-subpage-updated/page-or-subpage-updated.mjs (1)
14-14: LGTM: version bump is consistent.No behavior change; matches other components.
components/notion_api_key/actions/append-block/append-block.mjs (1)
14-14: LGTM: metadata-only change.Version sync with the rest of the Notion API Key suite.
components/notion_api_key/actions/create-page/create-page.mjs (1)
14-14: LGTM: version bump only.Consistent with package updates; no logic touched.
components/notion_api_key/sources/updated-page-id/updated-page-id.mjs (1)
14-14: Approve version bump and SDK upgrade — verified all notion_api_key sources at 0.0.2 and package.json at 0.1.2 with @notionhq/client 4.0.2 and @pipedream/notion ^0.10.1; repo scan shows no stray version declarations or breaking Client() uses.components/notion_api_key/actions/query-database/query-database.mjs (1)
14-14: LGTM on version bump.No functional changes; aligns with the package-wide patch bump.
components/notion_api_key/actions/retrieve-block/retrieve-block.mjs (1)
14-14: LGTM on version bump.Consistent with other actions; no behavior changes introduced.
components/notion_api_key/sources/new-page/new-page.mjs (1)
14-14: LGTM on version bump.Matches the coordinated 0.0.2 update across sources.
components/notion_api_key/actions/create-page-from-database/create-page-from-database.mjs (1)
14-14: LGTM on version bump.No structural or prop changes; safe metadata update.
components/notion_api_key/actions/update-page/update-page.mjs (2)
14-14: Version bump only — looks good.No logic changes; safe metadata update.
11-22: Confirm Node.js runtime is ≥18 for Notion SDK v4
Package.json currently only specifiespnpmunderengines. Add an"engines": { "node": ">=18" }entry (or otherwise verify that the deployed Pipedream runtime is v18+), to guarantee compatibility with @notionhq/client v4.components/notion_api_key/actions/create-comment/create-comment.mjs (2)
14-14: Version bump acknowledged.Consistent with the PR’s patch-level updates; no behavior changes.
11-22: Confirm runtime compatibility with Notion SDK v4.If the package.json moved to @notionhq/client 4.x (ESM, Node 18+), ensure the Pipedream runtime for this component is Node 18+ and that the shared @pipedream/notion wrapper shields any breaking changes.
components/notion_api_key/sources/new-database/new-database.mjs (1)
14-14: LGTM on source version bump.Metadata-only; aligns with other sources.
components/notion_api_key/actions/retrieve-page-property-item/retrieve-page-property-item.mjs (1)
14-14: LGTM.Patch version increment only; no functional diff.
components/notion_api_key/actions/retrieve-database-content/retrieve-database-content.mjs (1)
14-14: OK to merge.Version metadata updated; behavior unchanged.
Follow-up to #18292
Summary by CodeRabbit