Skip to content

Conversation

michelle0927
Copy link
Collaborator

@michelle0927 michelle0927 commented Oct 1, 2025

Resolves #18590

Will create follow-up PR to update Google Docs create-document-from-template which imports from Google Drive.

Summary by CodeRabbit

  • New Features

    • Creating a Google Drive file from a template no longer requires selecting a destination folder; the folder field is now optional.
  • Chores

    • Incremented action and package versions for the Google Drive integration.

Copy link

vercel bot commented Oct 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
pipedream-docs Ignored Ignored Oct 1, 2025 4:13pm
pipedream-docs-redirect-do-not-edit Ignored Ignored Oct 1, 2025 4:13pm

Copy link
Contributor

coderabbitai bot commented Oct 1, 2025

Walkthrough

Updates the Google Drive “create-file-from-template” action to version 0.1.15 and marks the folderId prop as optional. Also bumps the package version from 1.1.0 to 1.1.1. No other logic or dependency changes are indicated.

Changes

Cohort / File(s) Summary of Changes
Google Drive create-file-from-template action
components/google_drive/actions/create-file-from-template/create-file-from-template.mjs
Version bumped 0.1.14 → 0.1.15; folderId propDefinition updated to include optional: true.
Package version bump
components/google_drive/package.json
Package version bumped 1.1.0 → 1.1.1; no dependency or field changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Action as Google Drive Action
  participant GDocs as google-docs-mustaches
  participant Drive as Google Drive API

  User->>Action: Invoke create-file-from-template(title, templateId, [folderId?])
  alt folderId provided
    Action->>GDocs: createFromTemplate(templateId, title, { destinationId: folderId })
  else folderId omitted
    Action->>GDocs: createFromTemplate(templateId, title)  Note over Action,GDocs: No destinationId
  end
  GDocs->>Drive: Copy template and populate
  Drive-->>GDocs: New file metadata
  GDocs-->>Action: Result (fileId, link, ...)
  Action-->>User: Return result
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A nibble of code, a hop of delight,
Folder paths optional, lighter than light.
Templates bloom where templates dwell,
Defaults guide the way so well.
Version bumps patter—tap, tap, tap—
A happy hare commits this patch. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Linked Issues Check ⚠️ Warning The pull request implements the optional folderId change for the Google Drive create-file-from-template action as required but does not address the same change for the Google Docs create-document-from-template action specified by the linked issue, resulting in only partial fulfillment of the objectives. Include the corresponding update to the Google Docs create-document-from-template action within this PR or clearly document its separation to ensure all linked issue requirements are met.
Description Check ⚠️ Warning The pull request description does not follow the repository’s required template and lacks the WHY section detailing the rationale for making the folderId parameter optional, instead only noting the linked issue resolution and a follow-up plan. Please update the description to include the WHY section per the template, summarizing the motivation for the change, the problem it solves, and how the library’s fallback behavior is leveraged.
✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title clearly articulates the primary change to the create-file-from-template action by specifying that the folderId prop is being made optional and identifies the affected Google Drive component, making it concise and directly relevant to the changeset.
Out of Scope Changes Check ✅ Passed All modifications in the pull request are directly related to making the folderId parameter optional and corresponding version bumps, and no unrelated or out-of-scope changes are present.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch issue-18590

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
components/google_drive/actions/create-file-from-template/create-file-from-template.mjs (1)

28-36: Consider updating the description to reflect the optional nature.

The optional: true flag correctly implements the PR objective. However, the description could be clearer about the behavior when folderId is not provided.

Consider updating the description to mention the fallback behavior:

     description:
-        "Select the folder of the newly created Google Doc and/or PDF, or use a custom expression to reference a folder ID from a previous step.",
+        "Optionally select the folder for the newly created Google Doc and/or PDF, or use a custom expression to reference a folder ID from a previous step. If not provided, the file will be created in the same location as the template.",
     optional: true,
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6df7a61 and 2b53add.

📒 Files selected for processing (2)
  • components/google_drive/actions/create-file-from-template/create-file-from-template.mjs (2 hunks)
  • components/google_drive/package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Lint Code Base
  • GitHub Check: pnpm publish
  • GitHub Check: Publish TypeScript components
  • GitHub Check: Verify TypeScript components
🔇 Additional comments (3)
components/google_drive/package.json (1)

3-3: LGTM!

The patch version bump is appropriate for this backward-compatible change.

components/google_drive/actions/create-file-from-template/create-file-from-template.mjs (2)

11-11: LGTM!

The patch version bump is appropriate for this backward-compatible change.


61-114: No changes needed: fallback behavior for undefined destination verified. google-docs-mustaches v1.2.2 places generated files alongside the source template when no folderId is provided.

Copy link
Collaborator

@luancazarine luancazarine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michelle0927, LGTM! Ready for QA!

@vunguyenhung vunguyenhung merged commit e8871a0 into master Oct 2, 2025
10 checks passed
@vunguyenhung vunguyenhung deleted the issue-18590 branch October 2, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ACTION] Fix: google_docs-create-document-from-template: Make folderId parameter optional
3 participants