-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Google Drive - create-file-from-template - make folderId prop optional #18596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
WalkthroughUpdates the Google Drive “create-file-from-template” action to version 0.1.15 and marks the folderId prop as optional. Also bumps the package version from 1.1.0 to 1.1.1. No other logic or dependency changes are indicated. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Action as Google Drive Action
participant GDocs as google-docs-mustaches
participant Drive as Google Drive API
User->>Action: Invoke create-file-from-template(title, templateId, [folderId?])
alt folderId provided
Action->>GDocs: createFromTemplate(templateId, title, { destinationId: folderId })
else folderId omitted
Action->>GDocs: createFromTemplate(templateId, title) Note over Action,GDocs: No destinationId
end
GDocs->>Drive: Copy template and populate
Drive-->>GDocs: New file metadata
GDocs-->>Action: Result (fileId, link, ...)
Action-->>User: Return result
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/google_drive/actions/create-file-from-template/create-file-from-template.mjs (1)
28-36
: Consider updating the description to reflect the optional nature.The
optional: true
flag correctly implements the PR objective. However, the description could be clearer about the behavior whenfolderId
is not provided.Consider updating the description to mention the fallback behavior:
description: - "Select the folder of the newly created Google Doc and/or PDF, or use a custom expression to reference a folder ID from a previous step.", + "Optionally select the folder for the newly created Google Doc and/or PDF, or use a custom expression to reference a folder ID from a previous step. If not provided, the file will be created in the same location as the template.", optional: true,
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
components/google_drive/actions/create-file-from-template/create-file-from-template.mjs
(2 hunks)components/google_drive/package.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Lint Code Base
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
🔇 Additional comments (3)
components/google_drive/package.json (1)
3-3
: LGTM!The patch version bump is appropriate for this backward-compatible change.
components/google_drive/actions/create-file-from-template/create-file-from-template.mjs (2)
11-11
: LGTM!The patch version bump is appropriate for this backward-compatible change.
61-114
: No changes needed: fallback behavior for undefineddestination
verified. google-docs-mustaches v1.2.2 places generated files alongside the source template when nofolderId
is provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michelle0927, LGTM! Ready for QA!
Resolves #18590
Will create follow-up PR to update Google Docs create-document-from-template which imports from Google Drive.
Summary by CodeRabbit
New Features
Chores