Skip to content

Conversation

GTFalcao
Copy link
Collaborator

@GTFalcao GTFalcao commented May 10, 2022

Sources

  • New message received (created new source)
  • New email opened (created new source)

Actions

  • Send an email (updated existing action)
  • Send an email with template (created new action)

GTFalcao added 4 commits May 5, 2022 21:46
Creating "send email with template"
Adjusted to a formatted string that is converted to an object
Reusing propDefinitions and methods across both Postmark actions
@vercel
Copy link

vercel bot commented May 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pipedream-docs ✅ Ready (Inspect) Visit Preview May 24, 2022 at 0:35AM (UTC)
pipedream-docs-redirect-do-not-edit ✅ Ready (Inspect) Visit Preview May 24, 2022 at 0:35AM (UTC)

@dylburger
Copy link
Contributor

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

@GTFalcao GTFalcao linked an issue May 10, 2022 that may be closed by this pull request
@GTFalcao GTFalcao changed the title [WIP] 1527 - Postmark new actions [WIP] #1527 - Postmark new actions and triggers May 10, 2022
@GTFalcao GTFalcao changed the title [WIP] #1527 - Postmark new actions and triggers #1527 - Postmark new actions and triggers May 13, 2022
Improved use of pd-axios, and created wrapper methods for requests
Corrected and standardized some request params as well
Copy link
Collaborator

@andrewjschuang andrewjschuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GTFalcao thanks for the changes, Looks very good!

Added just a few more comments.

You can also make sharedActionRequest() accept a custom http method and call it on GET - listTemplates() and PUT - setServerInfo() requests

andrewjschuang
andrewjschuang previously approved these changes May 20, 2022
Copy link
Collaborator

@andrewjschuang andrewjschuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GTFalcao thanks for the changes! LGTM!

To remind the user of a limitation documented by Postmark
To further describe the 'html body' vs 'open tracking' relation
@GTFalcao
Copy link
Collaborator Author

/approve

@GTFalcao GTFalcao dismissed lcaresia’s stale review May 24, 2022 22:02

Changes were addressed and approved

@GTFalcao GTFalcao merged commit 40f929c into master May 24, 2022
@GTFalcao GTFalcao deleted the 1527-postmark-new-actions branch May 24, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ACTION / SOURCE] Postmark new actions

5 participants