-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[ACTION / SOURCE] #1527 - Postmark new actions #2823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Creating "send email with template"
Adjusted to a formatted string that is converted to an object
Reusing propDefinitions and methods across both Postmark actions
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
|
Also fixed a reference error.
Improved use of pd-axios, and created wrapper methods for requests
Corrected and standardized some request params as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GTFalcao thanks for the changes, Looks very good!
Added just a few more comments.
You can also make sharedActionRequest()
accept a custom http method
and call it on GET - listTemplates()
and PUT - setServerInfo()
requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GTFalcao thanks for the changes! LGTM!
To remind the user of a limitation documented by Postmark
To further describe the 'html body' vs 'open tracking' relation
/approve |
Sources
Actions