[Gmail] Custom OAuth Components #4125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lcaresia
approved these changes
Aug 30, 2022
| _client() { | ||
| const auth = new gmail.auth.OAuth2(); | ||
| auth.setCredentials({ | ||
| access_token: this.$auth.oauth_access_token, |
There was a problem hiding this comment.
Move this to a getter method.
Suggested change
| access_token: this.$auth.oauth_access_token, | |
| access_token: this._accessToken(), |
|
Testing is skipped since there are some prerequisites required for testing. @andrewjschuang please ship it and @dannyroosevelt will perform the testing. |
alysonturing
pushed a commit
that referenced
this pull request
Aug 31, 2022
* master: (22 commits) Adding app scaffolding for gmail Adding app scaffolding for gmail Modifying global config Adding app scaffolding for crisp Adding app scaffolding for crisp Adding app scaffolding for crisp Modifying global config Gmail Custom OAuth minor fixes (#4126) [Gmail] Custom OAuth Components (#4125) Fixed postgres event (#4115) Adding app scaffolding for gmail_custom_oauth Adding app scaffolding for gmail_custom_oauth Adding app scaffolding for gmail_custom_oauth Modifying global config Update send-large-message.mjs TimeCamp #3812 (#4084) Small updates to Slack components (#4108) add default false value (#4117) Sources - ClickUp (#4101) Esputnik - new sources and actions (#4105) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds components for new Gmail Custom OAuth app.
Note: the app is currently hidden from the UI, so I wasn't able to test them.
Resolves #4121.