[BUG] pCloud Watch Folder trigger does not pick up events

[michelle0927]

Resolves #4136

The created and modified file dates from pCloud do not represent dates that the file was uploaded or modified within pCloud, but the original creation/modification dates of the file being uploaded.

I updated the component to dedupe on fileid to find newly created files, and hash (64 bit integer representing hash of the contents of the file can be used to determine if two files are the same or to monitor file contents for changes) to find modified files.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
pipedream-docs	✅ Ready (Inspect)	Visit Preview	Sep 5, 2022 at 3:21PM (UTC)
pipedream-docs-redirect-do-not-edit	✅ Ready (Inspect)	Visit Preview	Sep 5, 2022 at 3:21PM (UTC)

[dylburger]

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

• Create components to address specific use cases whenever possible
• Component keys should follow the format app_name_slug-slugified-component-name
• Components should follow the standard directory structure
• Prefer Node.js client libraries to REST APIs
• When making API requests, handle pagination to ensure all data / events are processed
• Use secret props to capture sensitive data
• Props and methods should be defined in app files whenever possible
• Document methods with JS Docs
• Use optional props whenever possible, and set a default value where you can
• Use async options to accept user input wherever possible
• Create subscription webhooks sources (vs polling sources) whenever possible
• Always emit a summary with events
• Use a built-in deduping strategy wherever possible
• When building webhook sources, follow these best practices
• When building polling sources, follow these best practices

[jcortes]

HI @michelle0927 LGTM! Ready for QA!

[DilanAthukorala]

@michelle0927

1. After I synced the created files, I changed the settings to receive "Modified" files. Then the files which were not modified synced again. (Those file were already received as create events)

2. And when I change file names in pCloud they were not synced to Pipedream as modified file events.

[michelle0927]

@michelle0927

1. After I synced the created files, I changed the settings to receive "Modified" files. Then the files which were not modified synced again. (Those file were already received as create events)

This happens because the component is deduping by fileid for new files, but by hash for modified files. Sources/triggers use various ways of determining what is a new event, so changing the configuration of any Pipedream source is likely to produce unexpected results. For sources, you'll want to deploy them with the configuration you want. To try different configurations, it's best to deploy multiple sources.

2. And when I change file names in pCloud they were not synced to Pipedream as modified file events.

That's correct. Events will be emitted when there is a change to the file contents.

[DilanAthukorala]

@michelle0927

1. After I synced the created files, I changed the settings to receive "Modified" files. Then the files which were not modified synced again. (Those file were already received as create events)

This happens because the component is deduping by fileid for new files, but by hash for modified files. Sources/triggers use various ways of determining what is a new event, so changing the configuration of any Pipedream source is likely to produce unexpected results. For sources, you'll want to deploy them with the configuration you want. To try different configurations, it's best to deploy multiple sources.

2. And when I change file names in pCloud they were not synced to Pipedream as modified file events.

That's correct. Events will be emitted when there is a change to the file contents.

@michelle0927 Ok Noted. Thanks for the explanation.

[DilanAthukorala]

Verification completed and ready for release.