Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/my contributions #2083

Merged
merged 32 commits into from
Jun 13, 2024
Merged

Feature/my contributions #2083

merged 32 commits into from
Jun 13, 2024

Conversation

mohitb35
Copy link
Collaborator

@mohitb35 mohitb35 commented May 31, 2024 •
edited
Loading

Changes:

  1. Implements MyContributions UI and functionality
  2. Sets up stories for all subcomponents
  3. Utilizes data from trpc contributions and projectList endpoints to populate list.

Pending - to be done in a separate PR

  1. Empty state management
  2. Loading management
  3. Minor background bleed issue for rounded outside borders while displaying gift label
  4. Responsiveness adjustments to be done in conjunction with other features on the page. e.g. Feature/my contributions #2083 (comment)

@vercel Vercel
Copy link

vercel bot commented May 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
planet-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 0:22am
planet-webapp-multi-tenancy-setup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 0:22am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
planet-webapp-temp ⬜️ Ignored (Inspect) Jun 12, 2024 0:22am

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 31, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mohitb35 mohitb35 changed the base branch from develop to feature/my-forest-v2 May 31, 2024 06:31
@mohitb35
refactor: refactors ProfileCardButton for reuse
97c37b7 
- renames component to WebappButton and moves to /common
- renames `color` prop to `variant`
- refactors WebappButton for readability
- adds tertiary button variant
- makes icon prop truly optional without showing an empty space when icon is missing
- adds stories for different button types
@mohitb35
feat: implements Donate Button for MyContributions
cd242ad 
- also updates WebappButton  to allow overrides to button styles
@mohitb35 mohitb35 marked this pull request as ready for review June 11, 2024 08:31
@mohitb35 mohitb35 mentioned this pull request Jun 11, 2024
Merged
@sunilsabatp

This comment was marked as resolved.

Sign in to view
@mohitb35

This comment was marked as resolved.

Sign in to view
@sunilsabatp

This comment was marked as outdated.

Sign in to view
@sunilsabatp

This comment was marked as outdated.

Sign in to view
@mohitb35
Copy link
Collaborator Author

The UI does not look good on the iPad version image

Agree, will be taken up as adjustments after all parts are merged to the base PR. That will help keep things consistent.

@mohitb35

This comment was marked as resolved.

Sign in to view
sunilsabatp
sunilsabatp requested changes Jun 12, 2024
View reviewed changes
src/features/common/WebappButton/index.tsx Outdated Show resolved Hide resolved
src/features/common/WebappButton/index.tsx Show resolved Hide resolved
src/features/user/MFV2/MyContributions/ListHeader.tsx Show resolved Hide resolved
src/features/user/MFV2/MyContributions/index.tsx Show resolved Hide resolved
src/features/user/MFV2/MyContributions/RegistrationItemCard.tsx Show resolved Hide resolved
src/features/user/MFV2/MyContributions/GiftLabel.tsx Show resolved Hide resolved
src/features/user/MFV2/MyContributions/ProjectSummary.tsx Show resolved Hide resolved
src/features/user/MFV2/MyContributions/ProjectItemCard.tsx Outdated Show resolved Hide resolved
src/features/user/MFV2/MyContributions/ProjectHeader.tsx Show resolved Hide resolved
@mohitb35 mohitb35 mentioned this pull request Jun 13, 2024
Merged
4 tasks
@mohitb35 mohitb35 merged commit 742e2e5 into feature/my-forest-v2 Jun 13, 2024
4 checks passed
@mohitb35 mohitb35 deleted the feature/my-contributions branch June 13, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunilsabatp sunilsabatp sunilsabatp approved these changes

Assignees
No one assigned
Labels
MyForest 2.0 PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohitb35 @sunilsabatp @mariahosfeld