Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- added package json #80

Closed
wants to merge 3 commits into from
Closed

- added package json #80

wants to merge 3 commits into from

Conversation

sini-codes
Copy link
Contributor

No description provided.

pgilmorepf
pgilmorepf suggested changes Dec 9, 2017
View reviewed changes
PlayFabSdk/package.json Outdated
"description": "Playfab SDK for JS client applications",
"license": "Apache-2.0",
"scripts": {
"test": ".\\tests\\run.bat"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no tests folder...

@sini-codes
Copy link
Contributor Author

OK I removed {script:tests} and version things.

  1. To run tests, we have to configure some complex stuff like silenium driver, and make it run the qunit. It is possible and I can take care of it, but you gotta tell me explicitly that you want it, as it might be something complicated

  2. I removed version because I don't know how to figure current package version...

@pgilmorepf pgilmorepf mentioned this pull request Dec 21, 2017
Closed
@pgilmorepf
Copy link
Contributor

Moved this commit to the SdkGenerator, and accepted.
PlayFab/SDKGenerator#116

@pgilmorepf pgilmorepf closed this Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgilmorepf pgilmorepf pgilmorepf requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sini-codes @pgilmorepf