removing crash dump processing logic from this solution... #44
Conversation
… to be in VmAgent sln. Added CrashDumpState to SessionHostHeartbeatInfo
| @@ -9,7 +9,7 @@ | |||
| --> | |||
| <GeneratePackageOnBuild>True</GeneratePackageOnBuild> | |||
| <PackageId>PlayFab.MultiplayerServers.AgentInterfaces</PackageId> | |||
| <PackageVersion>5.1.5</PackageVersion> | |||
| <PackageVersion>5.2.0</PackageVersion> | |||
There was a problem hiding this comment.
This change is the definition of a minor version change--it's a backwards-compatible change to the public API (i.e. i added a field to SessionHostHeartbeatInfo)
| @@ -3,7 +3,7 @@ | |||
| <PropertyGroup> | |||
| <TargetFrameworks>netcoreapp3.1</TargetFrameworks> | |||
| <GeneratePackageOnBuild>true</GeneratePackageOnBuild> | |||
| <PackageVersion>1.1.10</PackageVersion> | |||
| <PackageVersion>1.2.0</PackageVersion> | |||
There was a problem hiding this comment.
This change should technically be a major version bump--i removed a method from a public-facing interface (ISessionHostManager), which is a breaking change. I opted for bumping the minor version instead though because it was a method that wasn't in use yet.
I'd prefer bumping the major version over bumping the patch version, though, because changing the patch version implies that there is no change to the public API. We should only be bumping the patch version if it's an implementation change that doesn't affect compilation.
There was a problem hiding this comment.
fair enough, though our internal code is the only consumer of these APIs. LGTM!
...it's going to be in VmAgent sln. Also added CrashDumpState to SessionHostHeartbeatInfo