v1.3.10 - Added getProfile and updateProfile commands to provision proxy #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmomii
approved these changes
Aug 8, 2018
ggentzel
approved these changes
Aug 8, 2018
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "playnetwork-sdk", | |||
| "version": "1.3.8", | |||
| "version": "1.3.10", | |||
There was a problem hiding this comment.
why did we skip over 1.3.9 here?
There was a problem hiding this comment.
disregard this comment and the thing about needing pulling. i see what happened there now. i think just the one comment below that order should probably be profile copypaste issue need addressing
ggentzel
reviewed
Aug 8, 2018
lib/provision.js
Outdated
| if (typeof options === 'function') { | ||
| callback = options; | ||
| options = undefined; | ||
| if (typeof order === 'function') { |
There was a problem hiding this comment.
should order be profile instead, copypasta?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.