[common] Added resize with 2 arguments to PointCloud
#4225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaltyagi
added
changelog: enhancement
aPonza
reviewed
Jun 27, 2020
| * \param[in] value the value to initialize the new points with | ||
| */ | ||
| void | ||
| resize(index_t count, const PointT& value) |
There was a problem hiding this comment.
Why not have the same parameter name/docstring of the base resize? I can understand not changing size_t to index_t for the old version to not break API, but the name change is unnecessary, I'd choose one of the two, and one of the two docstrings as well.
There was a problem hiding this comment.
This one is copied from https://en.cppreference.com/w/cpp/container/vector/resize
Which one is better? I can make them the same
There was a problem hiding this comment.
I'd definitely opt for the standard's copy
aPonza
approved these changes
Jun 29, 2020
SergioRAgostinho
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cast addressed in separate PR
Required for #4217, #4218