Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for clipping with exact coordinates #149

Closed
gabrieldansereau opened this issue Feb 17, 2023 · 1 comment · Fixed by #152 or #153
Closed

Add a test for clipping with exact coordinates #149

gabrieldansereau opened this issue Feb 17, 2023 · 1 comment · Fixed by #152 or #153
Assignees
@gabrieldansereau
Labels
bug Something isn't working component:SimpleSDMLayers priority:high

Comments

@gabrieldansereau
Copy link
Member

Add a test for the fix in #144. This should also test for non-natural values with 0.5 or 0.25 increments
@gabrieldansereau gabrieldansereau self-assigned this Feb 17, 2023
@gabrieldansereau gabrieldansereau mentioned this issue Feb 17, 2023
Merged
@gabrieldansereau
Copy link
Member Author

Also we should add another specifically for the 1st bug described in #144, where _match_latitude does not return the right index for the coordinate.

This is a different issue from the approximation one occurring in clip itself.

@tpoisot tpoisot mentioned this issue Feb 18, 2023
Merged
4 tasks
@tpoisot tpoisot moved this to In progress in Species Distribution Toolkit Feb 18, 2023
@github-project-automation github-project-automation bot moved this from In progress to Done in Species Distribution Toolkit Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabrieldansereau gabrieldansereau

Labels
bug Something isn't working component:SimpleSDMLayers priority:high
Projects
Species Distribution Toolkit
Status: Done
Milestone
No milestone
2 participants
@tpoisot @gabrieldansereau