Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using stride when clipping #150

Closed
gabrieldansereau opened this issue Feb 17, 2023 · 1 comment · Fixed by #153
Closed

Avoid using stride when clipping #150

gabrieldansereau opened this issue Feb 17, 2023 · 1 comment · Fixed by #153
Assignees

Comments

@gabrieldansereau
Copy link
Member

clip currently uses the stride, which might return approximation errors as in #144.

@tpoisot had an idea to avoid using stride completely. Possibly using indices instead of coordinates?

@tpoisot
Copy link
Member

tpoisot commented Feb 17, 2023

I'm going to take a look at where we use stride internally, because I think we would get rid of so much edge cases by using indexing directly. I'll open a PR when I'm done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants