pointing model is likely not included

[EranOfek]

In the gledmagicwater branch, it seems that the point model is not included,
while it was applied in the previous stable branch used in the LAST observing run in March.

We see that in the gledmagicwater headers, ADRA and and ARA (as well as ADDec and ADec) are equal, while in the previous run they were different. The difference between these two parameters is the pointing model offset (taken from LAST_config/obs.PointingModel).
To verify this, it seems that the offset in astrometry between images taken in the March run and in the June run are consistent with the point model offsets.

Ruslan can add some examples.

[RuslanKonno]

I was writing the same issue, so I'll just copypaste it here:

The data taken during the June nights of 2024-06-03 to 2024-06-05 show misalignment with reference images taken in March 2024. This is at least confirmed for mounts M1, M3, M6, M8.

Inspecting the headers of the images, e.g.,

/marvin/LAST.01.06.02/2024/06/03/proc/220200v0/LAST.01.06.02_20240603.220150.321_clear_1209_000_001_010_sci_coadd_Image_1.fits

shows that the mount A and AD coordinates are the same, implying that the full pointing correction was not applied. Example for the image above:

M_ARA = 229.5725 /
M_AHA = 28.6867 /
M_ADEC = 20.9185 /
M_ADRA = 229.5725 /
M_ADHA = 28.6867 /
M_ADDEC = 20.9185 /

When registering the June images to the March reference images of the same field, the misalignment is clearly seen. Below is the reference image registered to the example new image.

Measuring the misalignment (green lines in the image above) gives similar values to the missing pointing offset

Measured misalignment:
(Delta RA, Delta Dec) = ~(0.299, 0.428)

Offset given by the pointing model at (HA, Dec) = (26.668319, 27.098529)
(Delta RA, Delta Dec) = ~( -0.220345, -0.451985)

Mind I'm only measuring the absolute misalignment, so I'm ignoring the sign. Also, the offset is taken from the nearest coordinates in obs.pointingModel.06_1.create.yml, which is not exactly the same as the image coordinates, so the shown measured misalignment won't closely match the expected offset, they do agree in the leading order floating point position.

This is consistent with the misalignment seen in at least M1 as well.

[EastEriq]

Code notes:

• when pointing, unitCS.observeByPriority2 calls mount.goToTarget2 at

  LAST_OCS/+obs/@unitCS/obsByPriority2.m

  Line 223 in e796c19

  Unit.Mount.goToTarget2(T.RA(IndPrio), T.Dec(IndPrio));

  with only 3 arguments, hence ApplyDist=true. celestial.convert.j2000_toApparent is called at

  LAST_OCS/+obs/@mount/goToTarget2.m

  Line 101 in e796c19

  [OutRA, OutDec, Alt, Refraction, Aux] = celestial.convert.j2000_toApparent(RA, Dec, JD,...

• when building the (Unit) header, unitCS.constructUnitHeader calls mount.pointingCorrection at

  LAST_OCS/+obs/@unitCS/private/constructUnitHeader.m

  Line 144 in e796c19

  Aux = MountObj.classCommand(sprintf('pointingCorrection([],%.8f)',JD));

  . That in turns calls celestial.convert.apparent_toJ2000, also with 'ApplyDistortion',true at

  LAST_OCS/+obs/@mount/pointingCorrection.m

  Line 52 in e796c19

  [OutRA, OutDec, Alt, Refraction, Aux] = celestial.convert.apparent_toJ2000(...

[EastEriq]

Note that there have been these two recent modifications to AstroPack, which could come (wrongly) into play here:

• celestial.convert.apparent_toJ2000 should provide standard values with empty pointing model EranOfek/AstroPack#437
• celestial.convert.j2000_toApparent returns NaNs for default arguments EranOfek/AstroPack#442

[EranOfek]

Can you please provide more details into: 437 and 442.

…

On Thu, Jun 6, 2024 at 10:06 PM EastEriq ***@***.***> wrote: Note that there have been these two recent modifications to AstroPack, which could come (wrongly) into play here: - EranOfek/AstroPack#437 <EranOfek/AstroPack#437> - EranOfek/AstroPack#442 <EranOfek/AstroPack#442> — Reply to this email directly, view it on GitHub <#27 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJUQ4N5O2AA5FDDACOF6WDZGCXMFAVCNFSM6AAAAABI46L3UOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJTGIZDMNRYG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[EastEriq]

Details of what? The changes done and their original motivation are referenced there. This is why we use a linked ticked system and reference the commits pertinent to each issue.

[EastEriq]

Seems that the problem was in a typo in celestial.convert.j2000_toApparent and apparent_toJ2000 on the AstroPack side. We have now pushed the fix (EranOfek/AstroPack@e4e875f), but the fix has still to be tested on sky. AstroPack should be pulled in the observatory but we are offline at the moment.

Please close when confirmed working.

[EastEriq]

Confirmed solved in last nights images by Ruslan