-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
write software version keys in the FITS image headers #28
Labels
enhancement
New feature or request
Milestone
Comments
blumzi
pushed a commit
to EastEriq/LAST_Messaging
that referenced
this issue
Jun 9, 2024
blumzi
pushed a commit
to EastEriq/LAST_Handle
that referenced
this issue
Jun 9, 2024
blumzi
pushed a commit
to EastEriq/LAST_tinycontrolIPpowerSocket
that referenced
this issue
Jun 9, 2024
blumzi
pushed a commit
to EastEriq/LAST_CelestronFocusMotor
that referenced
this issue
Jun 9, 2024
blumzi
pushed a commit
to EastEriq/LAST_QHYccd
that referenced
this issue
Jun 9, 2024
blumzi
pushed a commit
that referenced
this issue
Jun 9, 2024
If needed you can use: tools.git.getVersion |
completed with 16fa4a0 and EastEriq/LAST_Handle@bf7bd10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm writing the ticket here because the code saving the observed images is in this repo.
We need such a feature to better identify the images which were written with code suffering of some known flaw, or without a feature introduced at a given point of time. The date of the observation itself does not tell all the story, because the image may have been written by a computer using this or that workspace set, or by a computer using outdated software.
Issue #27 is an example of this - we have for sure now three observation nights which saved images with an incorrect application of the pointing model - but images taken for the first hour of the night of 5/6/2024 on M1 were taken with a different branch of the code, so the date itself is not eloquent, and this information is not an integral part of the image.
One way I envision in order to implement it, is to add hidden properties to each LAST_Handle object, storing the value of the current git branch, SHA,
git_describe
. Then, as the header is created, this data is used to generate specific entries for each of the components involved (likely, Unit, camera, focuser, Messenger etc...) which all represented by some subobject of the Unit class.The text was updated successfully, but these errors were encountered: