QR Decomposition Method Object Refactoring #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…per understanding.
…ng logic to the new method object.
… be a matrix of minor.
… more similar to decompose.
hemalvarambhia
requested review from
SergeStinckwich,
Ducasse,
khinsen and
olekscode
… decomposition methods.
hemalvarambhia
changed the title
SergeStinckwich
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work continues the refactoring, and has introduced a test that shows why the Moore Penrose Inverse test fails randomly: the pivot of the QR decomposition contains a
nil.I will try to delve deeper into why the pivot has a nil in it at all, and what the answer should be. I will give myself a few days. If I get nowhere, I will make this a full PR ready for review.