Refactor QR Decomposition #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able listing) even more similar.
hemalvarambhia
requested review from
SergeStinckwich,
olekscode and
Ducasse
hemalvarambhia
commented
Oct 9, 2022
| columnVectorFromRMatrix | ||
| atColumnNumber: col. | ||
| householderVector := householderReflection at: 1. | ||
| householderMatrix := householderReflection at: 2. |
There was a problem hiding this comment.
I want Housholder Reflection to become a first class object.
jordanmontt
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the simplification of the QR Decomposition method object. I have made the idea of the Householder Reflection explicit. I will continue to look more deeply into why the one element of the pivot (last one) is nil.