-
Notifications
You must be signed in to change notification settings - Fork 24
Zf/zkcuda_service mode #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6592ce8
to
f0cee2b
Compare
parallelized zkcuda for keccak pass. |
4ed546c
to
00471ea
Compare
4ed546c
to
0b8c7a2
Compare
…n the broadcast cast
…ilerCollection into zf/service_mode
siq1
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently calling mpi executor whenever we receive a request to prove a circuit. This works but the circuit needs to be reloaded each time we call the
prove
, which is very costly. This PR targets at making the proving a service so that the circuit can be pre-loaded.axum
package is a big issue now).It is still too costly to call the proving service kernel-by-kernel. To remedy this, we'd like to group the witness together and pass it to the service at once. Note that this breaks the current zkcuda framework a little bit, so we're changing the zkcuda framework first to allow more flexible proving system.
Known Issues
When there are not enough physical cores, mpi overscribe will be enabled, but the proving will fail. MPI apis do not seem to behave as expected in the overscription mode.