fix(issuer): display dummy page for incompatible browsers #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
display dummy page for incompatible browsers
RafaelVidaurre
suggested changes
Sep 21, 2018
add constant for readability improvements
RafaelVidaurre
previously approved these changes
Sep 21, 2018
|
Please bear in mind that browsers that are incompatible with react (e.g. IE) may not even process this far. We should have a snippet load up at the beginning. |
RafaelVidaurre
approved these changes
Oct 3, 2018
|
@josepmc maybe this is something we want to check before merging then |
|
@josepmc I guess what you are saying would make sense for |
|
I think it'd be wise for us to avoid any possible mishaps by an external library and just insert any snippet before anything, that would cover us in any situation. |
|
@RafaelVidaurre I think you can merge this. We have an issue already in place for what Josep suggested. |
|
@Grsmto thanks, I'll do that then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
display dummy page for incompatible browsers