Coverage problems solved #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
external folder skipped for coverage coverage only runs on PR
pabloruiz55
approved these changes
Sep 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to solidity-coverage 0.5.10
External folder skipped for coverage
Coverage only runs on PR
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
TravisCI fails on coverage builds
What is the new behavior?
TravisCI runs coverage only for PR, ignoring 'a_poly_oracle.js' tests and skipping external folder to avoid solidity-coverage issue with 'oraclizeAPI.sol'
Does this PR introduce a breaking change?
No