Skip to content
This repository was archived by the owner on Jul 6, 2022. It is now read-only.

Conversation

ashneverdawn
Copy link

No description provided.

@ashneverdawn
Copy link
Author

@VictorVicente some tests failing here. Is this another compatibility issue? Not sure which approach to take here, could you take a look? Thanks.

@VictorVicente
Copy link
Collaborator

@VictorVicente some tests failing here. Is this another compatibility issue? Not sure which approach to take here, could you take a look? Thanks.

Yes, these tests are failing because Kusama and Polkadot were upgraded to latest Substrate and we haven't upgrade to upstream.
The approach should be the same, just ignore them or comment them until we upgrade.
Ideally, if we are planning to keep using the harvester for a while, we should develop these tests pointing to Polymesh. That way we could ensure everything works fine with the substrate version we are using and that's all what we need. cc @satyamakgec

Copy link

@Tamir-Polymath Tamir-Polymath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashneverdawn ashneverdawn merged commit e1fdced into alpha Feb 17, 2021
@ashneverdawn ashneverdawn deleted the feature/NCBD-168-schema-v2.5.0 branch February 17, 2021 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants