Add tests for link interception. #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,10 +61,13 @@ | |||
| }); | |||
| } | |||
|
|
|||
| function makeAbsoluteUrl(path) { | |||
|
Super minor long-winded feedback. Otherwise LGTM 👍 |
Also add support for the target attribute of anchor tags based on the docs at https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#attr-target Fixes #15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved logic from PolymerElements/app-route#95 while splitting it up and ensuring that even when clicks aren't captured there will never be a navigation.
Also added support for the
targetattribute of anchor tags based on the docs at https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#attr-targetFixes #15