Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nested repeat test #6

Closed
wants to merge 1 commit into from
Closed

nested repeat test #6

wants to merge 1 commit into from

Conversation

atotic
Copy link

@atotic atotic commented May 15, 2015

Added a test that demonstrates a bug with dom-repeat fixtures on Safari.

@atotic
Copy link
Author

atotic commented May 20, 2015

@cdata
Found the cause: Safari.importNode nested template contents are not cloned.
Bug was reported, and patched, but patch obviously not shipping yet:
https://bugs.webkit.org/show_bug.cgi?id=137619
There is another call to importNode in polymer/src/mini/template.html that might be affected by this.
Writing safariImportNode() workaround is left as an exercise to the reader.

@cdata
Copy link
Contributor

cdata commented May 20, 2015

Nice find! Hopefully we can work around this.

On Tue, May 19, 2015 at 10:53 PM, Aleksandar Totic <notifications@github.com

wrote:

@cdata https://github.com/cdata
Found the cause: Safari.importNode nested template contents are not cloned.
Bug was reported, and patched, but patch obviously not shipping yet:
https://bugs.webkit.org/show_bug.cgi?id=137619
There is another call to importNode in polymer/src/mini/template.html that
might be affected by this.
Writing safariImportNode() workaround is left as an exercise to the reader.


Reply to this email directly or view it on GitHub
#6 (comment)
.

<template>
<template id="repeater" is="dom-repeat">
<div>{{item}}</div>
</template>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't a dom-repeat require bound items in order to actually repeat something? Where do you set the items?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does require items. Bug happens before items are even generated, template-repeater gets an empty template. Trust me, importNode is the culpit.

@atotic
Copy link
Author

atotic commented May 20, 2015

Bug is already known: Polymer/polymer#1443
If you read through, kevin suggests using dom-if, since they already handle this in their stamping code. But, test-fixture is not a polymer element, so.....

cdata added a commit that referenced this pull request Jun 28, 2015
fix missing custom headers
@cdata
Copy link
Contributor

cdata commented Oct 5, 2015

@atotic after talking with the core guys, I don't think this test will ever pass (even when the "bug" in Polymer is fixed). I'm gonna close the PR for now, let's talk about it offline!

@cdata cdata closed this Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants