This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
release: ship debug symbols in image for continuous profiling #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvello
force-pushed
the
xvello/debug2
branch
from
5d3734b
to
ef09c04
Compare
xvello
force-pushed
the
xvello/debug2
branch
from
ef09c04
to
5303ca8
Compare
bretthoerner
approved these changes
Dec 11, 2023
ellie
approved these changes
Dec 11, 2023
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable debug symbols on the
releaseprofile as instructed in the Polar Signals documentation. This will improve the quality of the continuous profiles they'll collect.Impact on image size is sizeable, but IIRC prod cpu/mem usage should not be impacted:
If the image size becomes an issue, we can setup the CI to send them the debug symbols separately, but I'd rather not go there for the initial test.