This repository has been archived by the owner on Nov 4, 2021. It is now read-only.
Slightly change the way changing team_id by plugins is illegal
#396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
yakkomajuri
reviewed
May 19, 2021
| export class IllegalOperationError extends Error { | ||
| name = 'IllegalOperationError' | ||
|
|
||
| constructor(operation: string) { |
There was a problem hiding this comment.
not even sure it's a nit, but I don't think you need the constructor if it just calls super. The constructor of the parent class should be called anyway if this is omitted. Fine if you like the explicitness though.
|
Great work everyone in getting to this solution! LGTM. |
fuziontech
pushed a commit
to PostHog/posthog
that referenced
this pull request
Oct 12, 2021
… is illegal (PostHog/plugin-server#396) * Slightly change the way changing team_id by plugins is illegal * Prettier * Remove debug console.log
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
So this PR adds the feature to batch processing like #394, but instead of silently restoring the correct
team_id(unlike master which nullifies the event), it restores it AND throws an IllegalOperationError. This way the impact of illegally operating plugins is minimized, but the problem is still communicated as an error. Closes #394.Checklist