Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed some functions from utils #9

Merged

Conversation

serhii-lyshchenko
Copy link

What does this PR do?
It renames some functions from utils.

Where should the reviewer start?
It just renames few functions from utils, and replaces their name with new ones throughout the project.

How should this be manually tested?
It shouldn't cause build errors when this package and https://github.com/segmentio/analytics-ios are using together.

Any background context you want to provide?
It's impossible to use PostHog library together with Segment library on iOS. It happens because PostHog iOS package is based on Segment package, and they have duplicating function names which is causing failing of app build.

What are the relevant tickets?
https://github.com/PostHog/posthog-react-native/issues/2

Screenshots or screencasts (if UI/UX change)

Questions:

  • Does the docs need an update?
  • Are there any security concerns?
  • Do we need to update engineering / success?

@mariusandra mariusandra merged commit 5439998 into PostHog:master Feb 24, 2021
@mariusandra
Copy link
Contributor

Thanks @serhey-dev for this! Apologies for the wait, yet 1.2.3 is now out with the change. I'll update the RN repo next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants