fix: Axios issue in Cloudflare workers #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
approved these changes
Dec 5, 2023
marandaneto
approved these changes
Dec 5, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Hopefully fixes #127
And also #129
Changes
The current version of Axios fixes a security issue but has other issues regarding environments like Cloudflare.
Tried to look for a general fix here but the world of polyfilled Fetch is a mess to say the least... In the end, the workaround that made most sense was to simply use fetch if it is defined (which it is in custom environments like Cloudflare workers.
Also added an example project for testing this - managed to recreate the issue and this PR fixes it.
Release info Sub-libraries affected
Bump level
Libraries affected
Changelog notes
fetchif available, otherwise imports and uses axios as a polyfill