-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feature-flags): Add bootstrap option for feature flags #24
Conversation
It does - It's right after the standard tests https://github.com/PostHog/posthog-js-lite/blob/master/.github/workflows/ci.yml#L22
Expo is a hard beast to test but for this we can stick to the unit tests. They have to be run separate to the other tests due to some specific tsconfig rules for React Native...
Sure - I'll check it out! |
@neilkakkar trying to fix the tests but not sure what the logic should be.
My assumption is we don't want to immediately reload the flags from the API if they are given. Is that correct? |
No, this is okay! The idea is that some flags are available on immediate load, while we wait for |
@neilkakkar this looks good now and everything passes. Turns out memorystorage for RN was always broken anyway so this is a good catch... Might be worth a quick glance for yourself over what I changed but if that's all good then I'd say we are good to go |
Much appreciated, thanks! I just added a test for the async storage as well. |
Just like PostHog/posthog-js#444 but for react-native.
@benjackwhite I could use some help figuring out this works for react-native.
Current issues I'm facing:
posthog-react-native
?