Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove defaults for feature flag calls #72

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

neilkakkar
Copy link
Collaborator

@neilkakkar neilkakkar commented Aug 11, 2022

Also fixes #71

Reason -> Additional spec: PostHog/posthog#10459 (comment)

@neilkakkar neilkakkar marked this pull request as ready for review August 11, 2022 13:29
Copy link
Contributor

@liyiy liyiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you mind updating the description with the link or context to why this should get removed just for posterity?

@neilkakkar
Copy link
Collaborator Author

Done!

@neilkakkar neilkakkar merged commit 81debce into master Aug 12, 2022
@neilkakkar neilkakkar deleted the ff-defaults branch August 12, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Posthog's logging overrides custom logging
2 participants