Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for running just Clickhouse in docker #1506

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

neilkakkar
Copy link
Contributor

Checklist

@@ -45,3 +45,14 @@ Currently for internal use only.
- Tests:
- All the same, except skip `DEBUG=1` in the env settings.
- Set as the "target" in run configuration `ee/clickhouse`

### Running everything but ClickHouse locally
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I think the section above here works, I think it's just a case of adding /etc/host instructions to that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are sort of different, since now postgres & redis are running locally as well? And ClickHouse is the only thing in docker

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, more importantly, since the above section also assumes plugin server is running inside docker, it doesn't face this specific issue at all.

Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mariusandra mariusandra enabled auto-merge (squash) June 29, 2021 10:50
@mariusandra mariusandra merged commit 29e18e0 into master Jun 29, 2021
@mariusandra mariusandra deleted the neilkakkar-patch-2 branch June 29, 2021 10:50
@alexkim205
Copy link
Contributor

oh looks like marius got to this one before me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants