Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel running queries trigger by dashboard #21557

Closed
2 tasks
timgl opened this issue Apr 16, 2024 · 1 comment
Closed
2 tasks

Cancel running queries trigger by dashboard #21557

timgl opened this issue Apr 16, 2024 · 1 comment
Labels
enhancement New feature or request feature/dashboards Feature Tag: Dashboards performance Has to do with performance. For PRs, runs the clickhouse query performance suite team/product-analytics

Comments

@timgl
Copy link
Collaborator

timgl commented Apr 16, 2024

In what situation are you experiencing subpar performance?

We don't cancel running queries triggered by dashboards, which causes performance issues

How to reproduce

  1. Open dashboard/refresh
  2. Navigate away
  3. See queries are still running

Environment

Additional context

Thank you for your performance issue report – we want PostHog to go supersonic!

@timgl timgl added the performance Has to do with performance. For PRs, runs the clickhouse query performance suite label Apr 16, 2024
@Twixes Twixes added enhancement New feature or request feature/dashboards Feature Tag: Dashboards team/product-analytics labels Jun 27, 2024
@webjunkie
Copy link
Contributor

We've talked about this in the team and decided this issue is no longer valid. For one, it dates back to when the frontend was issuing the queries, and you could actually see they are still made in the network tab.
We now have async queries on dashboards and are also reworking the cache warming. The goals are to get insights into the cache for users to see charts much more quickly. Canceling queries when the users wanted to look at a dashboard runs counter to that, we already spent some computing time, so we can just as well fill the cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature/dashboards Feature Tag: Dashboards performance Has to do with performance. For PRs, runs the clickhouse query performance suite team/product-analytics
Projects
None yet
Development

No branches or pull requests

3 participants