Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't have multiple filters with the same key #714

Closed
timgl opened this issue May 4, 2020 · 0 comments
Closed

Can't have multiple filters with the same key #714

timgl opened this issue May 4, 2020 · 0 comments
Labels
bug Something isn't working right
Projects
Parity (Roadmap phase 1)

Comments

@timgl
Copy link
Collaborator

timgl commented May 4, 2020

Describe the bug

Fairly silly, you can't have multiple filters that are the same, eg $current_url doesn't equal A and $current_url doesn't equal B

To Reproduce

  1. Try adding two filters anywhere

Expected behavior
Should filter by both

Additional context
this is obviously because we're using a dict. We might need to switch to using arrays with 'key'
@timgl timgl added the bug Something isn't working right label May 4, 2020
@timgl timgl added this to To do in Parity (Roadmap phase 1) via automation May 4, 2020
@mariusandra mariusandra mentioned this issue May 5, 2020
Merged
27 tasks
@timgl timgl moved this from To do to In progress in Parity (Roadmap phase 1) May 8, 2020
timgl added a commit that referenced this issue May 8, 2020
@timgl
Closes #714 allow multiple filters with same key
867b12e
@timgl timgl moved this from In progress to Review in progress in Parity (Roadmap phase 1) May 11, 2020
@timgl timgl closed this as completed in 80484e7 May 12, 2020
Parity (Roadmap phase 1) automation moved this from Review in progress to Done May 12, 2020
fuziontech added a commit to fuziontech/posthog that referenced this issue May 14, 2020
@fuziontech
Merge remote-tracking branch 'upstream/master'
b1da187 
* upstream/master:
  Updated Funnels to use antd (PostHog#751)
  Release 1.5.0 (PostHog#762)
  Speed up action/people by prefetching distinct_ids (PostHog#736)
  Fix all time no results (PostHog#725)
  add breakpoint (PostHog#754)
  Add ES Lint (PostHog#719)
  Resize dashboard items (PostHog#746)
  added conditions (PostHog#748)
  fixed undo bug (PostHog#750)
  Event Partitioning (PostHog#733)
  Closes PostHog#714 allow multiple filters with same key (PostHog#738)
  Fix Error404 (PostHog#744)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working right
Projects
No open projects
Parity (Roadmap phase 1)
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timgl