Resize dashboard items #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgl
approved these changes
May 12, 2020
|
And we have colors!
Right now only three: blue, green, purple. Unfortunately with colored backgrounds, we can't really use the default graph colors, so I just added different tones of the background color. I don't know if the end result very aesthetically pleasing or not, but I did my best not to have anything clash horribly. |
|
Looks great |
This was referenced May 13, 2020
Closed
fuziontech
added a commit
to fuziontech/posthog
that referenced
this pull request
May 14, 2020
* upstream/master: Updated Funnels to use antd (PostHog#751) Release 1.5.0 (PostHog#762) Speed up action/people by prefetching distinct_ids (PostHog#736) Fix all time no results (PostHog#725) add breakpoint (PostHog#754) Add ES Lint (PostHog#719) Resize dashboard items (PostHog#746) added conditions (PostHog#748) fixed undo bug (PostHog#750) Event Partitioning (PostHog#733) Closes PostHog#714 allow multiple filters with same key (PostHog#738) Fix Error404 (PostHog#744)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #704. I did use react-grid-layout in the end. This 20kb of gzipped (80kb minified) JS that's used on an internal dashboard page doesn't break the bank, as the minified payload is already about 1MB.
With this change, there are 4 layouts, which each can have items rearranged independently: Mobile, Tablet, Desktop, TV (HD resolution).
Please test and see if it works as you think it should.
There's just one bug that I didn't manage to fix yet: when you drag from the title (link), it visits the link after dragging. I'll try to get this fix in as well very soon.
Checklist