-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #714 allow multiple filters with same key #738
Conversation
I'm getting an error saving and then loading funnels with this.
The rest seems fine. And running through all these steps manually makes me wish for integration tests :). We'll miss something one of these days... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So like I wrote in the comment, funnels are broken.
Since funnels store these properties as JSON, all the old funnels still work, but if I save any of them, they will break.
Should be good now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, that's fixed now |
* upstream/master: Updated Funnels to use antd (PostHog#751) Release 1.5.0 (PostHog#762) Speed up action/people by prefetching distinct_ids (PostHog#736) Fix all time no results (PostHog#725) add breakpoint (PostHog#754) Add ES Lint (PostHog#719) Resize dashboard items (PostHog#746) added conditions (PostHog#748) fixed undo bug (PostHog#750) Event Partitioning (PostHog#733) Closes PostHog#714 allow multiple filters with same key (PostHog#738) Fix Error404 (PostHog#744)
Changes
[{key, value, operator, type}]
Checklist