Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed undo bug #750

Merged
merged 3 commits into from
May 13, 2020
Merged

fixed undo bug #750

merged 3 commits into from
May 13, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented May 12, 2020

Changes

  • Deletewithundo component wasn't working because of property mixup
  • fixed

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)

@EDsCODE EDsCODE requested review from timgl and mariusandra May 12, 2020 20:12
@timgl timgl temporarily deployed to posthog-undo-broken-v84xzjlckq May 12, 2020 20:13 Inactive
@timgl timgl temporarily deployed to posthog-undo-broken-v84xzjlckq May 12, 2020 20:14 Inactive
@timgl timgl temporarily deployed to posthog-undo-broken-v84xzjlckq May 12, 2020 20:33 Inactive
@mariusandra mariusandra merged commit c0e59fa into master May 13, 2020
@mariusandra mariusandra deleted the undo-broken branch May 13, 2020 08:38
timgl pushed a commit that referenced this pull request May 13, 2020
@EDsCODE @timgl
fixed undo bug (#750)
33d2b81 
* fixed undo bug

* change to const

* remove creepover
timgl added a commit that referenced this pull request May 13, 2020
@timgl @EDsCODE
Release 1.5.0 (#762)
9fb1c43 
* Changelog

* fixed undo bug (#750)

* fixed undo bug

* change to const

* remove creepover

* Bump version 1.5.0

Co-authored-by: Eric Duong <eeoneric@gmail.com>
fuziontech added a commit to fuziontech/posthog that referenced this pull request May 14, 2020
@fuziontech
Merge remote-tracking branch 'upstream/master'
b1da187 
* upstream/master:
  Updated Funnels to use antd (PostHog#751)
  Release 1.5.0 (PostHog#762)
  Speed up action/people by prefetching distinct_ids (PostHog#736)
  Fix all time no results (PostHog#725)
  add breakpoint (PostHog#754)
  Add ES Lint (PostHog#719)
  Resize dashboard items (PostHog#746)
  added conditions (PostHog#748)
  fixed undo bug (PostHog#750)
  Event Partitioning (PostHog#733)
  Closes PostHog#714 allow multiple filters with same key (PostHog#738)
  Fix Error404 (PostHog#744)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

@timgl timgl Awaiting requested review from timgl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EDsCODE @mariusandra @timgl