Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moving from sessions to trends #1039

Merged
merged 2 commits into from
Jun 19, 2020
Merged

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Jun 17, 2020

Changes

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)
  • Cypress E2E tests (if applicable)

@timgl timgl requested a review from mariusandra June 17, 2020 07:59
@timgl timgl temporarily deployed to posthog-fix-moving-from-gktccp June 17, 2020 08:01 Inactive
@timgl timgl temporarily deployed to posthog-fix-moving-from-gktccp June 18, 2020 09:32 Inactive
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd propose an alternative way of doing the same thing: 6748d37

Calling the "success" action explicitly outside of the loader feels like a hack. It's best to just use the power reducers give us and have the results reducer (via the loader) directly change itself when a tab is changed.

I'm approving the PR. Feel free to merge if you agree with the change.

@timgl
Copy link
Collaborator Author

timgl commented Jun 19, 2020

That's great, thanks!

@timgl timgl merged commit 720a6f2 into master Jun 19, 2020
@timgl timgl deleted the fix-moving-from-sessions-to-trends branch June 19, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants