feat: Resizeable replayer inspector #18378
Conversation
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
# Conflicts: # frontend/__snapshots__/lemon-ui-lemon-table--with-footer.png # frontend/src/layout/navigation-3000/components/Navbar.tsx # frontend/src/lib/components/Resizer/resizerLogic.ts # frontend/src/scenes/session-recordings/player/SessionRecordingPlayer.scss
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
…into feat/inspector-resizing
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
benjackwhite
added
waiting
|
Size Change: 0 B Total Size: 2 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
commenting here so we can thread :)
it felt like it should always be resizeable. it loaded I tried to grab it, I couldn't, then I collapsed a side menu and now I could grab it and resize it... confusing.
I think it's ok to have different min/max sizes based on screensize, but should always be resizable on desktop IMO
There was a problem hiding this comment.
Fair point. I was leaving the existing behaviour where it was always expanded when the container was large enough in place. That probably matters a lot less given it's resizeable.
Think the happy middle here is to always make it expanded when there is enough space, but to not disable resizing just because the screen is wide enough. Will implement that
There was a problem hiding this comment.
Chiming in! I think it should be always moveable / collapsable.
- Small screen: it is collapsed by default. You click it to open it, can resize it but clicking on the player (i.e. the bit behind it, collapses it.
- Big enough screen: Same behaviour except it doesn't float over the player, rather it is just next to it and you can resize within sensible bounds and collapse
In both cases I think it needs a button to hide as welll (not just the resizer)
Problem
We have a nice generic resizer - lets make the player resizeable!
Changes
WIP
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?