Add alt_host for graceful failover to our secondary clickhouse node #2407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a simple backwards compatible update that will allow us to either have a
CLICKHOUSE_URLbe a single node or multiple comma delimited nodes.If it is a
,delimited list then if the clickhouse driver is unable to connect to the first node it will sequentially try all of the hosts listed in the alternate list which is composed of the nodes listed after the first hostname in theCLICKHOUSE_URLlist.This enables us to do live failover drills of our clickhouse nodes as well as taking the primary node down for maintenace.