Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #231. Add mult-domain explanation #254

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Closes #231. Add mult-domain explanation #254

merged 1 commit into from
Mar 3, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Mar 2, 2020

No description provided.

@timgl timgl temporarily deployed to posthog-231-add-multi-d-9njrxq March 2, 2020 18:27 Inactive
@wundo
Copy link

wundo commented Mar 3, 2020

If the same snippet can be used in multiple sites, that is the hash used for?

@timgl
Copy link
Collaborator Author

timgl commented Mar 3, 2020

@wundo 2 reasons

  1. If there's an instance with multiple teams (like app.posthog.com) we need the snippet to work out which team the event is for.
  2. If someone takes your snippet and starts sending lots of spam, you can rotate the hash

@timgl timgl merged commit 3ad946b into master Mar 3, 2020
@mariusandra mariusandra deleted the 231-add-multi-domain-explanation branch April 30, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timgl @wundo