Sessions filtering system #2912

macobo · 2021-01-11T13:34:57Z

Changes

This PR:

Refactors SelectBox + PropertyFilters logic to be able to be reused in sessions filtering
Introduces sessions filtering logic
Introduces a way to save sessions filters
Refactors the backend to filter data based on parameters
Removes previous action filtering/recording duration filtering logic, replacing it with new system (closes Filter sessions by recording available #2281)

What this does not (yet) do:

Support multiple action filters on clickhouse
Supporting filtering via action filters on postgres
Nice UX
Making sessions page support viewing multiple dates at once
Cypress tests

These will be resolved in follow-up PRs. Paolo was promising to help with the design-side things.

Peek.2021-01-08.16-13.mp4

Checklist

All querysets/queries filter by Organization, by Team, and by User
Django backend tests
Jest frontend tests
Cypress end-to-end tests

paolodamico

QA'd and it seems to work as expected. As mentioned in the general PR description, will skip any comments on UX for a separate improvement.

A few additional comments:

Unsure if this should be considered part of this PR or not, but the filters no longer have the same styling (the same height issue is something I believe @EDsCODE was working on)
Again not sure if you want to leave for later, but after you save a filter, the filter dropdown still says "Custom filter" instead of the name of the newly saved filter.

Btw great job on the renaming of the columns on the sessions table, definitely clearer!

posthog/models/filters/mixins/sessions.py

posthog/models/filters/sessions_filter.py

posthog/models/sessions_filter.py

posthog/api/sessions_filter.py

paolodamico · 2021-01-12T13:49:35Z

frontend/src/lib/components/PropertyFilters/OperatorValueSelect.tsx

+                            onChange(currentOperator || 'exact', value)
+                        }}
+                    />
+                    {(operator === 'gt' || operator === 'lt') && isNaN(value) && (


Seems like trying to type a string still generated an error (see below). Also, because the HTML input is type="number" then a string will never be accepted and this error never shown (unless I'm unaware of a different behavior in other browsers).

I'd like to avoid refactoring this this PR - this bug was there previously, I just moved some code around.

paolodamico · 2021-01-12T13:55:19Z

frontend/src/lib/components/PropertyFilters/PropertySelect.tsx

+export function PropertySelect({ optionGroups, value, onChange, placeholder, autoOpenIfEmpty }: Props): JSX.Element {
+    return (
+        <SelectGradientOverflow
+            className={rrwebBlockClass}


Maybe worth adding this to the specific labels of non-default items so that the recordings make more sense? Feel free to disregard if outside the scope of the PR.

Let's keep it outside the scope

frontend/src/scenes/sessions/filters/SavedFiltersDropdown.tsx

posthog/api/sessions_filter.py

frontend/src/scenes/sessions/filters/SessionsEditFiltersPanel.tsx

macobo · 2021-01-13T08:49:41Z

Unsure if this should be considered part of this PR or not, but the filters no longer have the same styling (the same height issue is something I believe @EDsCODE was working on)

Good point, something that likely sneaked in via rebases.

This makes much more sense since you can select e.g. actions

Note that it's all relying on old 'paths' - will refactor these later.

This will require some discussion with Paolo - probably want to show this on the side?

macobo · 2021-01-13T12:37:38Z

Most of the issues have been solved.

Re select height, this was fixed by rebasing again.
Re custom selector - needed to introduce a new dependency, though it was already in our bundle.

timgl temporarily deployed to posthog-insane-filters-henjhqd January 11, 2021 13:37 Inactive

macobo temporarily deployed to posthog-insane-filters-henjhqd January 11, 2021 14:22 Inactive

macobo force-pushed the insane-filters branch from af1055c to 5272516 Compare January 11, 2021 14:37

macobo temporarily deployed to posthog-insane-filters-henjhqd January 11, 2021 14:37 Inactive

macobo requested a review from paolodamico January 11, 2021 15:39

macobo marked this pull request as ready for review January 11, 2021 15:39

paolodamico reviewed Jan 12, 2021

View reviewed changes

macobo added 22 commits January 13, 2021 13:57

Refactor adding filtering component

e2b2cc2

Fix a type error

14b3f52

Rename events to entries

6c9190e

This makes much more sense since you can select e.g. actions

Start of the session filter box

d4f027e

WIP: Sessions filtering

496727b

Make SelectBox more generic

1cc453f

Make sessions filtering visuals

e1b708b

Extract operator value selection code

113643a

Make action properties filterable

40d3c0b

Make it possible to filter by cohorts

d519f0b

Filtering by events

04049aa

Make loading sessions possible with the new logic

8f9ffb2

Make it possible to filter by actions/events via backend with new code

e7901b0

Note that it's all relying on old 'paths' - will refactor these later.

Make it possible to filter by user properties

2ef5996

Update imports

eaf2f10

Small fixes for sessions filter

cbf224a

Add UserFilter file

b6a5285

Ignore extra args to Property

6cbe234

Make it possile to filter by recording duration

fd10613

Update how session duration filter works in the backend

ac59f5e

Rename a few columns

147b4b5

Remove dead mixins

ea9c21c

macobo added 19 commits January 13, 2021 13:57

Remove duplicated logic, put code behind feature flag

3328ee9

Move sessions filters logic to subfolder

d21aa27

Don't show properties if feature flag.

8898fda

Add saved filters support

8662c01

This will require some discussion with Paolo - probably want to show this on the side?

Add divider before sessions table

eed04fe

Narrower typing for recordings

20c8f90

Some frontend for saving filters

69ede48

Small rename

797723c

Add SessionsFilter model

f595ba9

Save filter on backend

fe3e8e4

add missing filter

7a1671e

Extract const

7c658ff

Make ActionFilterDropdown be able to pick actions again.

50eafee

Fix links from person modal to sessions

64bd92f

Update tests.

22fdf13

Fix database model

182f8df

Use proper deep equal for detecting active filter

48de15e

Remove unneeded field

b1d104a

Only return filters from correct page

b7e4e49

macobo force-pushed the insane-filters branch from 5272516 to b7e4e49 Compare January 13, 2021 12:30

macobo temporarily deployed to posthog-insane-filters-henjhqd January 13, 2021 12:31 Inactive

macobo added 3 commits January 13, 2021 14:32

Add missing data-attr

c448ba0

Add instrumentation

9e427fd

rename component

c7a1929

macobo temporarily deployed to posthog-insane-filters-henjhqd January 13, 2021 12:35 Inactive

Fix analytics metadata

a3610ca

macobo temporarily deployed to posthog-insane-filters-henjhqd January 13, 2021 12:38 Inactive

macobo merged commit 19c50a2 into master Jan 13, 2021

macobo deleted the insane-filters branch January 13, 2021 12:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sessions filtering system #2912

Sessions filtering system #2912

macobo commented Jan 11, 2021 •

edited by paolodamico

Loading

paolodamico left a comment

paolodamico Jan 12, 2021

macobo Jan 13, 2021

paolodamico Jan 12, 2021

macobo Jan 13, 2021

macobo commented Jan 13, 2021

macobo commented Jan 13, 2021

Sessions filtering system #2912

Sessions filtering system #2912

Conversation

macobo commented Jan 11, 2021 • edited by paolodamico Loading

Changes

Checklist

paolodamico left a comment

Choose a reason for hiding this comment

paolodamico Jan 12, 2021

Choose a reason for hiding this comment

macobo Jan 13, 2021

Choose a reason for hiding this comment

paolodamico Jan 12, 2021

Choose a reason for hiding this comment

macobo Jan 13, 2021

Choose a reason for hiding this comment

macobo commented Jan 13, 2021

macobo commented Jan 13, 2021

macobo commented Jan 11, 2021 •

edited by paolodamico

Loading