Type trend logic #3152
Merged
Type trend logic #3152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EDsCODE
commented
Feb 2, 2021
| breakdown_value, | ||
| people.next | ||
| ) | ||
| } |
There was a problem hiding this comment.
since we're properly type checking now, what should we do if listeners do nothing here? maybe emit an error so we can log it? and show UI error
There was a problem hiding this comment.
Not sure what you mean - if they do nothing in what sense?
You mean if values.people is null?
If we think a state is impossible honestly an type assertion is ok here. e.g. const people = values.people as something or const { people: currPeople, count, action, label, day, breakdown_value, next } = values.people! though we have prohibited the latter.
There was a problem hiding this comment.
yeah ok we can roll with that
macobo
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please describe.
If this affects the frontend, include screenshots.
Checklist