Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add type and null check before reporting #3224

Merged
merged 4 commits into from
Feb 5, 2021
Merged

add type and null check before reporting #3224

merged 4 commits into from
Feb 5, 2021

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Feb 5, 2021

Changes

Please describe.

If this affects the frontend, include screenshots.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@EDsCODE EDsCODE requested a review from macobo February 5, 2021 20:20
@sentry-io
Copy link

sentry-io bot commented Feb 5, 2021

Sentry issue: POSTHOG-24K

macobo
macobo reviewed Feb 5, 2021
View reviewed changes
Copy link
Contributor

@macobo macobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks, feel free to merge once resolved

frontend/src/lib/utils/eventUsageLogic.ts Show resolved Hide resolved
frontend/src/scenes/persons/personsLogic.ts Outdated Show resolved Hide resolved
@timgl timgl temporarily deployed to posthog-report-null-per-qwcuml February 5, 2021 20:26 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-report-null-per-qwcuml February 5, 2021 20:35 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-report-null-per-qwcuml February 5, 2021 20:37 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-report-null-per-qwcuml February 5, 2021 20:40 Inactive
@EDsCODE EDsCODE merged commit 7455b8d into master Feb 5, 2021
@EDsCODE EDsCODE deleted the report-null-person-bug branch February 5, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo macobo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EDsCODE @macobo @timgl