Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make new Sessions filter UI responsive #3988

Merged
merged 3 commits into from
Apr 19, 2021
Merged

Make new Sessions filter UI responsive #3988

merged 3 commits into from
Apr 19, 2021

Conversation

samwinslow
Copy link
Contributor

@samwinslow samwinslow commented Apr 15, 2021 •
edited
Loading

Changes

BEFORE: No responsive repositioning of sidebar in Sessions. Weird overlap on scroll.

Screen.Cast.2021-04-14.at.5.52.51.PM.mp4

AFTER: Sidebar has position: sticky. Table stays in container.

Screen.Cast.2021-04-14.at.8.44.38.PM.mp4

AFTER: medium breakpoint

Screen Shot 2021-04-14 at 8 45 38 PM

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious

@timgl timgl temporarily deployed to posthog-pr-3988 April 15, 2021 00:52 Inactive
macobo
macobo approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@macobo macobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid stuff, no technical feedback from me!

Paolo still might want to take a look for the css side of things though

Aside - it might be worth cleaning up the dead feature flag as you're editing the code, but probably in a separate PR. :)

paolodamico
paolodamico approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@paolodamico paolodamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@paolodamico paolodamico merged commit 6a9b7c4 into master Apr 19, 2021
@paolodamico paolodamico deleted the sessions-filter-ui-responsive branch April 19, 2021 06:53
fuziontech pushed a commit that referenced this pull request Apr 19, 2021
@EDsCODE
Merge branch 'master' into 3765-cohort-by-trend
a213e60 
* master: (62 commits)
  Docker support on the Apple M1 chip / arm64 (#4024)
  Release session filters (#4030)
  Notify Sentry of production releases (#3998)
  Make new Sessions filter UI responsive (#3988)
  Change wording to be even clearer (#4027)
  Defer event fields on team model to make grabbing fields a bit more lazy (#4028)
  🤖: Add kevinhu as a contributor 🎉 (#4023)
  Patch 3638 (#4022)
  3638 trailing wau mau (#3929)
  Use virtual list for property select (#4020)
  Miscellaneous improvements (#4003)
  Autofocus filter dropdown (#3957)
  User ID convention naming (#3943)
  Pin prod docker-compose to Postgres 13 and Redis 6 (#4019)
  Invite sign up E2E tests (#3591)
  🤖: Add angelahuang89 as a contributor 🎉 (#4018)
  Set undefined user properties as undefined in webhooks messages (#3685)
  Avoid double-stacked <hr /> lines in trends (#4014)
  Update plugin server to 0.16.14 (#4017)
  Don't catch all exceptions for migrating clickhouse (#4016)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo macobo approved these changes

@paolodamico paolodamico paolodamico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samwinslow @macobo @paolodamico @timgl