Don't catch all exceptions for migrating clickhouse #4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is making it hard to wait until clickhouse has been set up for VPC deployments. It was introduced in https://github.com/PostHog/posthog/pull/2034/files#diff-ea7b79cfe0fd591ead9add4372dab5f31aa4f6155f304bc0d63ef667c9e8ac95L16 for an unknown reason
|
Yeah probably safe to merge, not sure why I did this |
fuziontech
pushed a commit
that referenced
this pull request
Apr 19, 2021
* master: (62 commits) Docker support on the Apple M1 chip / arm64 (#4024) Release session filters (#4030) Notify Sentry of production releases (#3998) Make new Sessions filter UI responsive (#3988) Change wording to be even clearer (#4027) Defer event fields on team model to make grabbing fields a bit more lazy (#4028) 🤖: Add kevinhu as a contributor 🎉 (#4023) Patch 3638 (#4022) 3638 trailing wau mau (#3929) Use virtual list for property select (#4020) Miscellaneous improvements (#4003) Autofocus filter dropdown (#3957) User ID convention naming (#3943) Pin prod docker-compose to Postgres 13 and Redis 6 (#4019) Invite sign up E2E tests (#3591) 🤖: Add angelahuang89 as a contributor 🎉 (#4018) Set undefined user properties as undefined in webhooks messages (#3685) Avoid double-stacked <hr /> lines in trends (#4014) Update plugin server to 0.16.14 (#4017) Don't catch all exceptions for migrating clickhouse (#4016) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is making it hard to wait until clickhouse has been set up for VPC
deployments.
It was introduced in
https://github.com/PostHog/posthog/pull/2034/files#diff-ea7b79cfe0fd591ead9add4372dab5f31aa4f6155f304bc0d63ef667c9e8ac95L16
for an unknown reason (debug code?)
Checklist