Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User ID convention naming #3943

Merged
merged 5 commits into from
Apr 16, 2021
Merged

User ID convention naming #3943

merged 5 commits into from
Apr 16, 2021

Conversation

paolodamico
Copy link
Contributor

Changes

Follow up on #3866 (comment).

  • Sends the user's uuid as uuid instead of id in the /api/users/@me endpoint.
  • Updates the frontend accordingly.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User. Not applicable.
  • Django backend tests
  • Jest frontend tests. Not applicable.
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious. Not applicable.

@paolodamico paolodamico requested a review from Twixes April 12, 2021 12:37
@timgl timgl temporarily deployed to posthog-pr-3943 April 12, 2021 12:40 Inactive
@Twixes Twixes temporarily deployed to posthog-pr-3943 April 16, 2021 13:44 Inactive
@Twixes Twixes temporarily deployed to posthog-pr-3943 April 16, 2021 14:06 Inactive
@Twixes Twixes temporarily deployed to posthog-pr-3943 April 16, 2021 14:28 Inactive
Twixes
Twixes approved these changes Apr 16, 2021
View reviewed changes
Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Twixes Twixes merged commit 917e6b7 into master Apr 16, 2021
@Twixes Twixes deleted the uuid-convention-naming branch April 16, 2021 14:44
fuziontech pushed a commit that referenced this pull request Apr 19, 2021
@EDsCODE
Merge branch 'master' into 3765-cohort-by-trend
a213e60 
* master: (62 commits)
  Docker support on the Apple M1 chip / arm64 (#4024)
  Release session filters (#4030)
  Notify Sentry of production releases (#3998)
  Make new Sessions filter UI responsive (#3988)
  Change wording to be even clearer (#4027)
  Defer event fields on team model to make grabbing fields a bit more lazy (#4028)
  🤖: Add kevinhu as a contributor 🎉 (#4023)
  Patch 3638 (#4022)
  3638 trailing wau mau (#3929)
  Use virtual list for property select (#4020)
  Miscellaneous improvements (#4003)
  Autofocus filter dropdown (#3957)
  User ID convention naming (#3943)
  Pin prod docker-compose to Postgres 13 and Redis 6 (#4019)
  Invite sign up E2E tests (#3591)
  🤖: Add angelahuang89 as a contributor 🎉 (#4018)
  Set undefined user properties as undefined in webhooks messages (#3685)
  Avoid double-stacked <hr /> lines in trends (#4014)
  Update plugin server to 0.16.14 (#4017)
  Don't catch all exceptions for migrating clickhouse (#4016)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paolodamico @Twixes @timgl