Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step time conversions for Unordered funnels #5024

Merged
merged 4 commits into from
Jul 7, 2021
Merged

Step time conversions for Unordered funnels #5024

merged 4 commits into from
Jul 7, 2021

Conversation

neilkakkar
Copy link
Collaborator

Changes

Resolves #5003

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@neilkakkar neilkakkar requested review from EDsCODE and Twixes July 7, 2021 11:21
Twixes
Twixes approved these changes Jul 7, 2021
View reviewed changes
Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@timgl timgl temporarily deployed to posthog-pr-5024 July 7, 2021 15:08 Inactive
@neilkakkar neilkakkar enabled auto-merge (squash) July 7, 2021 15:12
@neilkakkar neilkakkar merged commit 7d5e8a7 into master Jul 7, 2021
@neilkakkar neilkakkar deleted the unordered_time_conversions branch July 7, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

@EDsCODE EDsCODE Awaiting requested review from EDsCODE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get Strict and Unordered Funnels to return appropriate step conversion times
3 participants
@neilkakkar @Twixes @timgl